systemd: reintroduce "hostnamed, localed, timedated: disable methods that change system settings" patch #226192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches some more occurences, addresses upstream feedback, and was sent upstream at systemd/systemd#27274.
…t-cha.patch In NixOS, /etc is NOT read-only, and most things in /etc are symlinks to /etc/static, which is a symlink into the nix store - so the upstream systemd "/etc is read-only" detection doesn't work. Fixes NixOS#224080.
49 tasks
ElvishJerricco
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This reintroduces "[PATCH] hostnamed, localed, timedated: disable methods that change system settings."
As explained in #224080,
/etcis not read-only, but contains symlinks to the (read-only)/etc/static. We still want to keep that logic.With this change,
nixosTests.timezonesucceeds again.I also batched this PR with a rework of the fsck patch, as we were missing some locations. This now uses the same logic to find
fsck, and was sent to upstream in systemd/systemd#27274 (helping with #80038)Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)