Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yosys/plugins/ghdl.nix: fix build #226559

Merged
1 commit merged into from Apr 17, 2023
Merged

yosys/plugins/ghdl.nix: fix build #226559

1 commit merged into from Apr 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2023

Description of changes

Since 12cc34c all yosys plugins are expected to have a plugin attribute; without it they will not build. This commit adds one for yosys-ghdl.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Since 12cc34c all yosys plugins are expected to have a
`plugin` attribute; without it they will not build.  This commit
adds one for yosys-ghdl.
@ghost ghost merged commit 016a65f into NixOS:master Apr 17, 2023
@ghost ghost deleted the pr/fix/yosys/ghdl branch April 17, 2023 04:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant