-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit: drop PHP 8.0 support, add PHP 8.2 support #227026
Conversation
PHP 8.0 will be end-of-life before the end of life of the next stable version of NixOS. Related to NixOS#224505.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; untested
(CI tests are passing, so I'm inclined to merge) |
@LeSuisse you used |
Indeed it is wrong, thanks for catching it. I'm happy to merge the fix if you open a PR. |
Maybe I can submit a PR later today. I need some custom PHP config anyways. My current workaround is using: services.unit.package =
let
php82-unit =
(pkgs.php82.withExtensions (
{ all, enabled }:
enabled
++ (with all; [
imagick
redis
])
)).override
{
embedSupport = true;
apxs2Support = false;
systemdSupport = false;
phpdbgSupport = false;
cgiSupport = false;
fpmSupport = false;
};
in
pkgs.unit.overrideAttrs (
finalAttrs: previousAttrs: {
postConfigure = ''
${previousAttrs.postConfigure}
./configure php --module=php82 --config=${php82-unit.unwrapped.dev}/bin/php-config --lib-path=${php82-unit}/lib
'';
}
); |
Description of changes
Related to #224505
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Result of
nixpkgs-review
run on x86_64-linux 11 package built: