Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ravedude: init at 0.1.5 #227627

Merged
merged 1 commit into from
Apr 26, 2023
Merged

ravedude: init at 0.1.5 #227627

merged 1 commit into from
Apr 26, 2023

Conversation

rvarago
Copy link
Contributor

@rvarago rvarago commented Apr 22, 2023

Description of changes

This is a tool to make Rust development for AVR microcontrollers smoother by wrapping avrdude.

https://github.com/Rahix/avr-hal/tree/main/ravedude

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 22, 2023

src = fetchCrate {
inherit pname version;
sha256 = "wcY9fvfIn1pWMAh5FI/QFl18CV2xjmRGSwwoRfGvujo=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "wcY9fvfIn1pWMAh5FI/QFl18CV2xjmRGSwwoRfGvujo=";
hash = "wcY9fvfIn1pWMAh5FI/QFl18CV2xjmRGSwwoRfGvujo=";

Copy link
Contributor Author

@rvarago rvarago Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for pointing it out.

I had to prefix the hash with its type, to make it SRI-compatible. Otherwise, the build would fail as it cannot infer the algorithm:

error: hash 'wcY9fvfIn1pWMAh5FI/QFl18CV2xjmRGSwwoRfGvujo=' does not include a type, nor is the type otherwise known from context

Also, judging by some PRs merged lately, I reckon that's preferred.

sha256 = "wcY9fvfIn1pWMAh5FI/QFl18CV2xjmRGSwwoRfGvujo=";
};

cargoSha256 = "AOIrB0FRagbA2+JEURF41d+th0AbR++U5WKCcZmh4Os=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cargoSha256 = "AOIrB0FRagbA2+JEURF41d+th0AbR++U5WKCcZmh4Os=";
cargoHash = "AOIrB0FRagbA2+JEURF41d+th0AbR++U5WKCcZmh4Os=";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, thanks.

This is a tool to make Rust development for AVR microcontrollers
smoother by wrapping `avrdude`.

https://github.com/Rahix/avr-hal/tree/main/ravedude
@AndersonTorres AndersonTorres merged commit 2d2c3c0 into NixOS:master Apr 26, 2023
@rvarago rvarago deleted the feat/rv/ravedude branch April 26, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants