Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: (cross) take gnChromium from buildPackages #227708

Merged
merged 1 commit into from Jun 23, 2023
Merged

chromium: (cross) take gnChromium from buildPackages #227708

merged 1 commit into from Jun 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2023

Description of changes

${gnChromium}/bin/gn needs to be compiled for the buildPlatform since it is run at build time.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Apr 22, 2023
@ghost
Copy link
Author

ghost commented Apr 24, 2023

Alright, this project will need to wait until after ZHF.

@ghost ghost marked this pull request as draft April 24, 2023 02:14
@ghost ghost mentioned this pull request May 1, 2023
4 tasks
${gnChromium}/bin/gn needs to be compiled for the buildPlatform
since it is run at build time.
@ghost ghost marked this pull request as ready for review June 21, 2023 05:13
@Artturin Artturin merged commit 53bb154 into NixOS:master Jun 23, 2023
@ghost ghost deleted the pr/chromium/cross/gn branch June 26, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant