chromium: (cross) strip aarch64-linux-gnu- toolprefix only for native builds #227723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… builds Our existing chromium expression strips the `aarch64-linux-gnu-` prefix off of toolchain names (like `aarch64-linux-gnu-gcc`) for all `Aarch64` builds. But when we are doing a cross compile *to* an `Aarch64` hostPlatform we need to leave those prefixes in place. This commit makes the prefix-stripping conditional on the build being a native build.
ofborg
bot
added
6.topic: cross-compilation
|
Alright, this project will need to wait until after ZHF. |
ghost
marked this pull request as draft
ghost
mentioned this pull request
12 tasks
ghost
mentioned this pull request
4 tasks
ghost
marked this pull request as ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Our existing chromium expression strips the
aarch64-linux-gnu-prefix off of toolchain names (likeaarch64-linux-gnu-gcc) for allAarch64builds. But when we are doing a cross compile to anAarch64hostPlatform we need to leave those prefixes in place.This commit makes the prefix-stripping conditional on the build being a native build.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)