Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/deepin: init #227936

Merged
merged 7 commits into from
May 1, 2023
Merged

nixos/deepin: init #227936

merged 7 commits into from
May 1, 2023

Conversation

wineee
Copy link
Member

@wineee wineee commented Apr 24, 2023 •
edited
Loading

Description of changes

Adds the Deepin Desktop Environment to NixOS

Temporarily use kwin(plasma5) as window manager, but deepin/dde-kwin is still important for kwin effects

Test ON:
https://gist.github.com/wineee/eab3d40f9f60e37cfccf6c8ebe3502a7

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 24, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Apr 24, 2023
@wineee wineee force-pushed the dde branch 7 times, most recently from d465515 to 74265d6 Compare April 25, 2023 06:55
@wineee
Copy link
Member Author

wineee commented Apr 25, 2023 •
edited by wegank
Loading

@ofborg test deepin

@wineee wineee marked this pull request as ready for review April 25, 2023 09:12
@wineee wineee mentioned this pull request Apr 25, 2023
Closed
49 tasks
@wegank
Copy link
Member

wegank commented May 1, 2023

Capture d’écran 2023-05-01 à 08 34 36

Excellent work!

@wegank wegank merged commit b87aa62 into NixOS:master May 1, 2023
@wineee wineee deleted the dde branch September 1, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
Nix documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wineee @wegank