buildLuarocksPackage: fixes attributes being ignored

[teto]

follow up of #224553 where some arguments got ignored whil they were before taken into account.

Description of changes

@arcnmx any of your derivation you want to share to test this againt ?

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[arcnmx]

any of your derivation you want to share to test this againt ?

Perhaps anything that uses rockspecFilename rather than knownRockspec would make a fine test, since nothing in nixpkgs currently seems to use/test it (alternatively, deprecate that argument and require knownRockspec?)

A random example of a tool I use, but may be too simple of a test:

{ lua, fetchFromGitHub }: lua.pkgs.buildLuarocksPackage rec {
  pname = "lua-amalg";
  version = "0.8";
  src = fetchFromGitHub {
    owner = "siffiejoe";
    repo = pname;
    rev = "v${version}";
    sha256 = "1a569hrras5wm4gw5hr2i5hz899bwihz1hb31gfnd9z4dsi8wymb";
  };
  rockspecVersion = "scm-0";
  rockspecFilename = "amalg-${rockspecVersion}.rockspec";
}

[teto]

thanks for the review, if you think it's fine I let you merge. I'll defer the test to a good will who uses the feature.