Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross bootstrap stdenvs: fix build #228130

Closed

Conversation

GenericNerdyUsername
Copy link
Contributor

Description of changes

All arches in nix-build pkgs/top-level/release-cross.nix -A bootstrapTools.[arch].build --arg supportedSystems '[builtins.currentSystem]', with the exception of mips64el-linux-gnuabin32, should build now

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Apr 25, 2023
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Apr 25, 2023
@RaitoBezarius RaitoBezarius requested review from alyssais and a user April 25, 2023 14:13
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the subject line to follow the commit message format. Otherwise @zowoq will give me grief.

Please also put something in the commit message body about what was failing and why this fixes it. You can copy and paste the build failure from here: https://hydra.nixos.org/build/215849262/nixlog/32/tail if you like.

This was most likely broken by #209870 which switched from using statically-linked libisl to normal dynamically-linked libisl. We should make sure we're putting the correct one into the bootstrapFiles. I'm not sure this commit does that. I will investigate more closely but don't have time to do that today.

@ghost
Copy link

ghost commented Apr 26, 2023

@ghost ghost closed this Apr 26, 2023
@GenericNerdyUsername GenericNerdyUsername deleted the fix-bootstrap branch April 26, 2023 10:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant