gcc: flatten nested conditionals in libgcc.nix #228602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves readability in libgcc.nix by flattening the conditionals. This commit has no effect on eval except that when `langC && !enableLibGccOutput` the empty string will be added as a `preFixupLibGccPhase`. This will cause a global rebuild on Darwin as well as all pkgsCross stdenvs, but improve maintainability and readability going forward.
ghost
marked this pull request as draft
Artturin
reviewed
Sep 21, 2023
| '' | ||
| # no-op, to prevent the empty string from being removed from the environment. | ||
| + '' | ||
| true |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit improves readability in libgcc.nix by flattening the conditionals.
This commit has no effect on eval except that when
langC && !enableLibGccOutputthe empty string will be added as apreFixupLibGccPhase. This will cause a global rebuild on Darwin as well as all pkgsCross stdenvs, but improve maintainability and readability going forward.This should wait until after the 23.05 branch-off.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)