clonehero: 0.23.2.2 -> 1.0.0.4080

[kira-bruneau]

Description of changes

Expands on draft PR #228096 to support the latest version of Clone Hero: https://clonehero.net/2022/11/29/v1-release.html

This release also no longer requires any wrappers!! User configured files are now stored in ~/.clonehero and clonehero now no longer tries to read system fonts from /usr/share/fonts, so we don't need the fhs wrapper!

@syboxez

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[kira-bruneau]

Result of nixpkgs-review pr 229321 run on x86_64-linux 1

1 package blacklisted:

• nixos-install-tools

2 packages built:

• clonehero
• clonehero.doc

[wegank]

Breaking changes for 23.05 were restricted a few hours ago. Too bad.

[kira-bruneau]

Breaking changes for 23.05 were restricted a few hours ago. Too bad.

😢 Hmm, well I could add a wrapper script back that would keep all the files in the same directory, so then it wouldn't be a breaking change...

now that the wrapper is no longer necessary though, I'd prefer to keep things closer to upstream.

[syboxez]

Not sure if symlinking the directory is an option, but that should result in no breaking changes, assuming that ~/.clonehero doesn't already exist.

Alternatively, we could have a wrapper that prioritizes the upstream location over the old location. (Just by checking if ~/.clonehero exists, then checking if "~/.config/unity3d/srylain Inc_/Clone Hero" exists, then if niether exist, use ~/.clonehero)

[kira-bruneau]

That could potentially work, but I'm a bit cautious trying to paper over something that's designed to have an explicit migration step. I'm just not sure of all the potential ways that things could go wrong.

I think the safest best would be to copy the files over, but then you'd have duplicates between the two folders.

Although, I also think it would be smarter not to try to be clever about it and just shift it to next release (even though that really sucks 😞)

[wegank]

I think we can now rebase it for 23.11.