linux/kernel/generic.nix: assert if constraints would be ignored #230036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a real mess with the naming of the attribute which contains structured extra configuration: - Nixpkgs' linux kernel expression uses structuredExtraConfig. - NixOS uses extraStructuredConfig. - Nixpkgs' kernelPatches use extraStructuredConfig. At the moment, if the user uses the wrong convention the configuration constraints are silently dropped. Let's `assert` instead so they at least know that their request isn't being respected.
|
Sorry, duplicate of #227999 . I'm cleaning up my tree. |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
There appears to be a real mess with the naming of the attribute which contains structured extra configuration:
At the moment, if the user uses the wrong convention the configuration constraints are silently dropped. Let's
assertinstead so they at least know that their request isn't being respected.Things done