betterlockscreen: make dunst optional #231714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dunst is detected *and* awesomeWM is used (its internal notification system to be exact) then betterlockscreen waits for dunst to reply on the DBus. Due to dunstctl being in PATH through the wrapper, dunst will always be tried to reach. None of the workarounds mentioned in the awesome and betterlockscreen repos do not work with this version, as dunstctl is always called and has to time out first. In the current master of BLS there is a change that makes BLS check and env-var first, and would ignore any dunstctl in PATH. Once the new release happened this could still be used to reduce the closure size.
ofborg
bot
added
10.rebuild-darwin: 0
|
Result of 1 package built:
|
|
Result of 1 package built:
|
|
Result of 1 package built:
|
|
lgtm :) Feel free to merge |
SebTM
approved these changes
May 16, 2023
|
If I find time, I will do a new release for Betterlockscreen soon but I'm also searching for a new maintainer as I'm fully switched to sway so I need to run a VM/install X-server to test. |
|
I will probably not stay with BLS for long either. I have found quicker solutions für blurring but I can't find a way to tell BLS to just use the image unchanged. So I will probably end up implementing my own little wrapper for i3lock in the long term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When
dunstis detected and awesomeWM is used (its internal notification system to be exact)then b
etterlockscreenwaits for dunst to reply on the DBus. Due todunstctlbeing in PATHthrough the wrapper,
dunstwill always be tried to reach.None of the workarounds mentioned in the awesome and betterlockscreen repos do not work with
this version, as dunstctl is always called and has to time out first.
In the current master of BLS there is a change that makes BLS check and env-var first, and
would ignore any dunstctl in PATH.
Once the new release happened this could still be used to reduce the closure size.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)