Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble: fix crash caused by openssl3 thread unsafe evp implementation #232894

Merged
merged 1 commit into from
May 21, 2023

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented May 19, 2023

Description of changes

mumble-voip/mumble#5361 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from infinisil May 19, 2023 22:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels May 19, 2023
Copy link
Member

@felixsinger felixsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@felixsinger
Copy link
Member

@SuperSandro2000 Could you finish the checklist? I would like to have this merged so that it's included in the 23.05 release.

@felixsinger
Copy link
Member

Please also add the ticket from Mumble in your description of the pull request.

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 Could you finish the checklist? I would like to have this merged so that it's included in the 23.05 release.

yeah, yeah

@SuperSandro2000 SuperSandro2000 merged commit d57b341 into NixOS:master May 21, 2023
@SuperSandro2000 SuperSandro2000 deleted the mumble-openssl3 branch May 21, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants