Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule: format #234511

Merged
merged 1 commit into from
May 30, 2023
Merged

buildGoModule: format #234511

merged 1 commit into from
May 30, 2023

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 27, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq @ShamrockLee
buildGoModule: format
599252b 
Co-authored-by: Yueh-Shun Li <shamrocklee@posteo.net>
@zowoq
Copy link
Contributor Author

zowoq commented May 27, 2023

@ShamrockLee I've added you as co-author for this commit.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 27, 2023
@zowoq zowoq mentioned this pull request May 28, 2023
Merged
12 tasks
@ShamrockLee
Copy link
Contributor

With #234651, we'll be able to (optionally) outdent everything by one level. Would that be better, or should we go on with the current format change?

You're right about the decision to split the formatting change from the spelling change.

@zowoq
Copy link
Contributor Author

zowoq commented May 28, 2023

We may as well wait a bit and see what people think about #234651 first.

@zowoq
Copy link
Contributor Author

zowoq commented May 30, 2023

@ShamrockLee I think might just merge this anyway so we have a formatted file for other work to be based on, does that sound okay?

@zowoq zowoq marked this pull request as ready for review May 30, 2023 09:29
@zowoq zowoq requested review from kalbasit and Mic92 as code owners May 30, 2023 09:29
@zowoq zowoq merged commit 304940d into NixOS:master May 30, 2023
@zowoq zowoq deleted the buildgomod-fmt branch May 30, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShamrockLee ShamrockLee ShamrockLee approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zowoq @ShamrockLee