Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxManualConfig: set badPlatforms #237769

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

alyssais
Copy link
Member

Older kernels shouldn't be marked as supporting architectures that were only added to the kernel later.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Older kernels shouldn't be marked as supporting architectures that
were only added to the kernel later.
@alyssais alyssais added 6.topic: kernel The Linux kernel 6.topic: exotic Exotic hardware or software platform backport release-22.11 labels Jun 14, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Jun 14, 2023
@alyssais alyssais merged commit 5c5e5e2 into NixOS:master Jun 22, 2023
@alyssais alyssais deleted the linux-badPlatforms branch June 22, 2023 12:27
@github-actions
Copy link
Contributor

Backport failed for release-22.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.11
git worktree add -d .worktree/backport-237769-to-release-22.11 origin/release-22.11
cd .worktree/backport-237769-to-release-22.11
git checkout -b backport-237769-to-release-22.11
ancref=$(git merge-base 39b3edb19d29865da7d09b8590594e4ec2167cd3 2328a23b546c7fadff0612e702a96548feca73eb)
git cherry-pick -x $ancref..2328a23b546c7fadff0612e702a96548feca73eb

@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: exotic Exotic hardware or software platform 6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant