Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I bumped zenity since 3.92.0 is already an unstable version and there are crashes. With this bump it no longer requires
help2man
(I don't think we need to rundata/generate-manpage.sh
) though we never generate manpages beforeTested gtk4 bump with nautilus, budgie ssd titlebar via
system.replaceRuntimeDependencies
, launched adwaita-1-demo, and confirmed zenity did not add--class
support back (:upside_down_face:)(I am offline in the next few hours due to timezone and might not address your review fast)
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)