Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME updates 2023-06-14 #237774

Merged
merged 3 commits into from
Jun 14, 2023
Merged

GNOME updates 2023-06-14 #237774

merged 3 commits into from
Jun 14, 2023

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Jun 14, 2023

Description of changes

I bumped zenity since 3.92.0 is already an unstable version and there are crashes. With this bump it no longer requires help2man (I don't think we need to run data/generate-manpage.sh) though we never generate manpages before

Tested gtk4 bump with nautilus, budgie ssd titlebar via system.replaceRuntimeDependencies, launched adwaita-1-demo, and confirmed zenity did not add --class support back (:upside_down_face:)

(I am offline in the next few hours due to timezone and might not address your review fast)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs look good, if we're already on an alpha let's definitely move to a newer release.

@amaxine amaxine merged commit ddb6fe5 into NixOS:master Jun 14, 2023
@bobby285271 bobby285271 deleted the upd/gtk4 branch June 15, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants