Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal-bootstrap: make sources a non-tarballs.nixos.org FOD #238357

Merged
merged 3 commits into from Jun 26, 2023
Merged

minimal-bootstrap: make sources a non-tarballs.nixos.org FOD #238357

merged 3 commits into from Jun 26, 2023

Commits on Jun 18, 2023

  1. minimal-bootstrap: create top-level attr for bootstrap sources

    emilytrau authored and Adam Joseph committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    005cfc8 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. minimal-bootstrap: make sources a non-tarballs.nixos.org FOD

    This commit adjusts #232576 to break the
    fetchurl<->minimal-bootstrap-sources dependency cycle without
    needing an upload to tarballs.nixos.org.  It does this by appending
    the low-level FOD attributes onto the `runCommand` derivation.
    
      https://nixos.org/manual/nix/unstable/language/advanced-attributes.html#adv-attr-outputHash
    Adam Joseph committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    df720da View commit details
    Browse the repository at this point in the history
  2. separate minimal-bootstrap-sources from make-minimal-bootstrap-sources

    Ericson2314 observed that although FODs break the build-time cycle,
    they don't break the eval-time cycle.  This cycle must be broken in
    order to compute the derivation hash.
    
    make-minimal-bootstrap-sources does and always has depended on the
    full nixpkgs (including fetchFromGitHub).  This commit completely
    separates minimal-bootstrap-sources from it, so that
    minimal-bootstrap-sources now does not depend on
    make-minimal-bootstrap-sources (or nixpkgs) in any way.
    
    minimal-bootstrap-sources is now a "bare Nix" derivation.  It is an
    FOD whose builder always fails with an error message.
    Adam Joseph committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c8080b0 View commit details
    Browse the repository at this point in the history