Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass: alphabetical reordering of dependencies and adding package tests #241164

Merged
merged 2 commits into from
Jul 14, 2023
Merged

grass: alphabetical reordering of dependencies and adding package tests #241164

merged 2 commits into from
Jul 14, 2023

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Jul 2, 2023 •
edited
Loading

Description of changes

This PR provides following changes:

  • alphabetical reordering of dependencies
  • packages tests
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@imincik
grass: alphabetical reordering of dependencies
dbb11d0 
Code cleanup, no functional changes.
@ofborg ofborg bot requested review from willcohen, nh2 and sikmir July 2, 2023 20:19
@imincik imincik marked this pull request as draft July 2, 2023 20:30
@imincik imincik changed the title grass: alphabetical reordering of dependencies grass: alphabetical reordering of dependencies and adding package tests Jul 2, 2023
@imincik imincik marked this pull request as ready for review July 2, 2023 21:38
@imincik imincik requested a review from willcohen July 2, 2023 21:38
@imincik
Copy link
Contributor Author

imincik commented Jul 2, 2023

@willcohen , I added another commit to this PR which provides simple package tests. Would you please review again ? Thanks.

@willcohen
Copy link
Contributor

Looks good!

@ofborg ofborg bot requested a review from willcohen July 2, 2023 22:09
@imincik
Copy link
Contributor Author

imincik commented Jul 3, 2023

Thank you @willcohen for review.

@imincik imincik mentioned this pull request Jul 3, 2023
Merged
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jul 3, 2023
@imincik
pkgs(grass): alphabetical reordering of dependencies and adding packa…
853a4a9 
…ge tests

Nixpkgs PR:
NixOS/nixpkgs#241164
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jul 3, 2023
@imincik
pkgs(grass): alphabetical reordering of dependencies and adding packa…
a4936dc 
…ge tests

Nixpkgs PR:
NixOS/nixpkgs#241164
imincik added a commit to imincik/geospatial-nix that referenced this pull request Jul 11, 2023
@imincik
pkgs(grass): alphabetical reordering of dependencies and adding packa…
ed8c3b4 
…ge tests

Nixpkgs PR:
NixOS/nixpkgs#241164
@symphorien symphorien merged commit 4774ffc into NixOS:master Jul 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 Awaiting requested review from nh2

@sikmir sikmir Awaiting requested review from sikmir

@willcohen willcohen Awaiting requested review from willcohen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer 12.approvals: 1 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imincik @willcohen @mweinelt @symphorien