Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: remove -lc from SHLIB_LC instead of setting SHLIB_LC="" #243230

Closed
wants to merge 1 commit into from
Closed

gcc: remove -lc from SHLIB_LC instead of setting SHLIB_LC="" #243230

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 13, 2023

Currently testing.

Description of changes

Fix for breakage of pkgsCross.

#238154 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Fix for breakage of pkgsCross.<anything-windows-ish>
@ghost
Copy link
Author

ghost commented Jul 13, 2023

Rebased on top of #243248

@ofborg build pkgs.tests.cross.mbuffer

@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the fix-gccNoLibc branch October 22, 2023 07:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants