Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: if isM68k, look for libgcc_s.so.2 (instead of .so.1) #243615

Merged
2 commits merged into from Jul 19, 2023
Merged

gcc: if isM68k, look for libgcc_s.so.2 (instead of .so.1) #243615

2 commits merged into from Jul 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2023

Description of changes

Closes #243613

Currently verifying the fix.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost marked this pull request as ready for review July 19, 2023 20:58
@ghost ghost requested a review from matthewbauer as a code owner July 19, 2023 20:58
@ghost
Copy link
Author

ghost commented Jul 19, 2023

@ofborg build pkgsCross.m68k.stdenv

@ghost
Copy link
Author

ghost commented Jul 19, 2023

pkgsCross.m68k.stdenv on x86_64-linux — Success Details

@ghost ghost merged commit 07494a4 into NixOS:master Jul 19, 2023
13 of 14 checks passed
@ghost ghost deleted the pr/gcc/fix-m68k branch January 23, 2024 06:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgsCross.m68k.stdenv broken by #238154
0 participants