python310Packages.jupyterlab: 3.6.3 -> 4.0.3 #244209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
4101aa5
to
3799ee5
Compare
nim65s
suggested changes
Jul 18, 2023
There was a problem hiding this comment.
nixpkgs-review pr 244209 is showing:
error: builder for '/nix/store/xw2bzyg84g7jw05gx1cwdp0p6p8ybbdd-python3.10-jupyterlab-lsp-4.2.0.drv' failed with exit code 1;
last 10 log lines:
> adding 'jupyterlab_lsp-4.2.0.dist-info/RECORD'
> removing build/bdist.linux-x86_64/wheel
> Finished executing setuptoolsBuildPhase
> installing
> Executing pipInstallPhase
> /build/jupyterlab-lsp-4.2.0/dist /build/jupyterlab-lsp-4.2.0
> Processing ./jupyterlab_lsp-4.2.0-py3-none-any.whl
> ERROR: Could not find a version that satisfies the requirement jupyterlab<4.0.0a0,>=3.6.0 (from jupyterlab-lsp) (from versions: none)
> ERROR: No matching distribution found for jupyterlab<4.0.0a0,>=3.6.0
>
edit: jupyterlab-lsp is not yet compatible with 4.0.0: https://github.com/jupyter-lsp/jupyterlab-lsp/blob/master/python_packages/jupyterlab_lsp/setup.cfg#L40, ref jupyter-lsp/jupyterlab-lsp#949
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
3799ee5
to
0baf53c
Compare
If that's the only failure I think we should merge anyway. |
|
This was the first failure, so I stopped here. I'm running it again. |
|
tensorflow 2.11.1 is also failing. 2.13.0 is out, so maybe this can just be bumped. |
|
Result of 40 packages marked as broken and skipped:
6 packages failed to build:
165 packages built:
|
|
Ok, I might not be interpreting nixpkgs-review output correctly, but anyway here is what I got about tensorflow: ERROR: /build/source/tensorflow/python/eager/BUILD:18:11: Compiling tensorflow/python/eager/pywrap_tfe_src.cc failed: (Exit 1): gcc failed: error executing command /nix/store/bxic6j2whyg3z4h2x>
In file included from tensorflow/python/eager/pywrap_tfe_src.cc:55:
./tensorflow/python/util/stack_trace.h: In static member function 'static tensorflow::StackTrace tensorflow::StackTrace::Capture(int)':
./tensorflow/python/util/stack_trace.h:64:55: error: 'PyThreadState' {aka 'struct _ts'} has no member named 'frame'; did you mean 'cframe'?
64 | const PyFrameObject* frame = PyThreadState_GET()->frame;
| ^~~~~
| cframe
./tensorflow/python/util/stack_trace.h:66:56: error: invalid use of incomplete type 'const PyFrameObject' {aka 'const struct _frame'}
66 | for (; i < limit && frame != nullptr; frame = frame->f_back, ++i) {
| ^~
In file included from bazel-out/k8-opt/bin/external/local_config_python/python_include/Python.h:42,
from ./tensorflow/python/lib/core/numpy.h:35,
from ./tensorflow/python/eager/pywrap_tensor.h:21,
from tensorflow/python/eager/pywrap_tfe_src.cc:51:
bazel-out/k8-opt/bin/external/local_config_python/python_include/pytypedefs.h:22:16: note: forward declaration of 'PyFrameObject' {aka 'struct _frame'}
22 | typedef struct _frame PyFrameObject;
| ^~~~~~
./tensorflow/python/util/stack_trace.h:67:37: error: invalid use of incomplete type 'const PyFrameObject' {aka 'const struct _frame'}
67 | PyCodeObject* code_obj = frame->f_code;
| ^~
bazel-out/k8-opt/bin/external/local_config_python/python_include/pytypedefs.h:22:16: note: forward declaration of 'PyFrameObject' {aka 'struct _frame'}
22 | typedef struct _frame PyFrameObject;
| ^~~~~~
At global scope:
cc1plus: note: unrecognized command-line option '-Wno-unknown-warning' may have been intended to silence earlier diagnostics
ERROR: /build/source/tensorflow/lite/python/BUILD:68:10 Middleman _middlemen/tensorflow_Slite_Spython_Stflite_Uconvert-runfiles failed: (Exit 1): gcc failed: error executing command /nix/store>
INFO: Elapsed time: 3887.905s, Critical Path: 785.93s
INFO: 6843 processes: 761 internal, 6082 local.
FAILED: Build did NOT complete successfully |
Probably tensorflow isn't rebuilt by this PR. But k-diffusion is and fails because tensorflow does. |
|
jupyter-server fails to build on aarch64-linux and aarch64-darwin but that's probably an issue with upstream |
natsukium
reviewed
Jul 30, 2023
There was a problem hiding this comment.
about jupyter-server:
We can disable test_regression_is_hidden for darwin and test_copy_big_dir for aarch64-linux.
I built with doCheck = false and ran pytest on my local jupyter_server/ to check the results.
about jupyterlab-lsp:
I don't think jupyterlab-lsp will work with buildPythonApplication, so it will be broken this time.
Migration seems to be in progress.
jupyter-lsp/jupyterlab-lsp#949
Others:
LGTM
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
0baf53c
to
ba6261e
Compare
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
ba6261e
to
690e58e
Compare
dotlambda
commented
Aug 2, 2023
| description = "The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications"; | ||
| homepage = "https://github.com/jupyter-server/jupyter_server"; | ||
| license = licenses.bsdOriginal; | ||
| maintainers = [ maintainers.elohmeier ]; |
There was a problem hiding this comment.
@elohmeier Would you like to be a member of teams.jupyter?
| homepage = "https://jupyter.org/"; | ||
| maintainers = with maintainers; [ zimbatm ]; |
There was a problem hiding this comment.
@zimbatm Would you like to be a member of teams.jupyter?
There was a problem hiding this comment.
I'm not using jupyter, so probably best to remove me
| homepage = "https://github.com/jupyter/notebook"; | ||
| license = lib.licenses.bsd3; | ||
| maintainers = with lib.maintainers; [ fridh ]; |
There was a problem hiding this comment.
@FRidh Would you like to be a member of teams.jupyter?
|
Result of 42 packages marked as broken and skipped:
16 packages failed to build:
153 packages built:
|
|
I'm not sure why these packages had been successfully built. Should we patch them to use |
|
Anyway, I think it should be reported upstream. |
dotlambda
commented
Aug 3, 2023
There was a problem hiding this comment.
@ChrisReinke Please consider applying something like this patch upstream. I don't have an account on gitlab.inria.fr otherwise I would make a merge request.
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
e042bed
to
2c22bd6
Compare
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
2c22bd6
to
35aa291
Compare
|
dotlambda
force-pushed
the
jupyterlab-4.0.3
branch
from
19caa5c
to
ba873b2
Compare
Done. But I did not test their functionality. |
|
Thanks! LGTM for x86_64-linux. It seems to fail on aarch64-linux, I will check it later. |
GaetanLepage
approved these changes
Aug 7, 2023
|
Result of 54 packages marked as broken and skipped:
14 packages failed to build:
142 packages built:
|
Comment on lines
+100
to
+101
| ] ++ lib.optionals (stdenv.isLinux && stdenv.isAarch64) [ | ||
| "test_copy_big_dir" |
There was a problem hiding this comment.
This now seems to fail on x86_64-linux, too
Fix in #259428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://github.com/jupyterlab/jupyterlab/blob/v4.0.3/CHANGELOG.md
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)closes #223814
fixes #246725