Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter extensions: make sure to run tests (as much as possible) #244492

Merged
merged 6 commits into from
Aug 20, 2023
Merged

Jupyter extensions: make sure to run tests (as much as possible) #244492

merged 6 commits into from
Aug 20, 2023

Conversation

GaetanLepage
Copy link
Contributor

Description of changes

When introduced, those packages' tests did not have their tests run.
This PR enables them as much as possible.

Also, I updated python3Packages.nbconvert to its latest version.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from FRidh July 20, 2023 16:01
@GaetanLepage GaetanLepage marked this pull request as draft July 21, 2023 07:18
@GaetanLepage GaetanLepage marked this pull request as ready for review August 11, 2023 06:58
@ofborg ofborg bot requested a review from natsukium August 11, 2023 07:17
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 244492 run on x86_64-linux 1

82 packages marked as broken and skipped:
  • python310Packages.batchspawner
  • python310Packages.batchspawner.dist
  • python310Packages.dockerspawner
  • python310Packages.dockerspawner.dist
  • python310Packages.jupyterhub
  • python310Packages.jupyterhub-ldapauthenticator
  • python310Packages.jupyterhub-ldapauthenticator.dist
  • python310Packages.jupyterhub-systemdspawner
  • python310Packages.jupyterhub-systemdspawner.dist
  • python310Packages.jupyterhub-tmpauthenticator
  • python310Packages.jupyterhub-tmpauthenticator.dist
  • python310Packages.jupyterhub.dist
  • python310Packages.oauthenticator
  • python310Packages.oauthenticator.dist
  • python310Packages.qiskit
  • python310Packages.qiskit-aer
  • python310Packages.qiskit-aer.dist
  • python310Packages.qiskit-finance
  • python310Packages.qiskit-finance.dist
  • python310Packages.qiskit-ibmq-provider
  • python310Packages.qiskit-ibmq-provider.dist
  • python310Packages.qiskit-ignis
  • python310Packages.qiskit-ignis.dist
  • python310Packages.qiskit-machine-learning
  • python310Packages.qiskit-machine-learning.dist
  • python310Packages.qiskit-nature
  • python310Packages.qiskit-nature.dist
  • python310Packages.qiskit-optimization
  • python310Packages.qiskit-optimization.dist
  • python310Packages.qiskit-terra
  • python310Packages.qiskit-terra.dist
  • python310Packages.qiskit.dist
  • python311Packages.batchspawner
  • python311Packages.batchspawner.dist
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.dockerspawner
  • python311Packages.dockerspawner.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.fastai
  • python311Packages.fastai.dist
  • python311Packages.jupyterhub
  • python311Packages.jupyterhub-ldapauthenticator
  • python311Packages.jupyterhub-ldapauthenticator.dist
  • python311Packages.jupyterhub-systemdspawner
  • python311Packages.jupyterhub-systemdspawner.dist
  • python311Packages.jupyterhub-tmpauthenticator
  • python311Packages.jupyterhub-tmpauthenticator.dist
  • python311Packages.jupyterhub.dist
  • python311Packages.k-diffusion
  • python311Packages.k-diffusion.dist
  • python311Packages.oauthenticator
  • python311Packages.oauthenticator.dist
  • python311Packages.qiskit-aer
  • python311Packages.qiskit-aer.dist
  • python311Packages.qiskit-finance
  • python311Packages.qiskit-finance.dist
  • python311Packages.qiskit-ibmq-provider
  • python311Packages.qiskit-ibmq-provider.dist
  • python311Packages.qiskit-ignis
  • python311Packages.qiskit-ignis.dist
  • python311Packages.qiskit-nature
  • python311Packages.qiskit-nature.dist
  • python311Packages.qiskit-optimization
  • python311Packages.qiskit-optimization.dist
  • python311Packages.qiskit-terra
  • python311Packages.qiskit-terra.dist
  • python311Packages.spacy
  • python311Packages.spacy-loggers
  • python311Packages.spacy-loggers.dist
  • python311Packages.spacy-lookups-data
  • python311Packages.spacy-lookups-data.dist
  • python311Packages.spacy-transformers
  • python311Packages.spacy-transformers.dist
  • python311Packages.spacy.dist
  • python311Packages.textacy
  • python311Packages.textacy.dist
  • python311Packages.textnets
  • python311Packages.textnets.dist
  • python311Packages.treex
  • python311Packages.treex.dist
47 packages failed to build:
  • manim
  • manim.dist
  • pentestgpt
  • pentestgpt.dist
  • python310Packages.bambi
  • python310Packages.bambi.dist
  • python310Packages.dalle-mini
  • python310Packages.dalle-mini.dist
  • python310Packages.datashader
  • python310Packages.datashader.dist
  • python310Packages.elegy
  • python310Packages.elegy.dist
  • python310Packages.jupyter-contrib-nbextensions
  • python310Packages.jupyter-contrib-nbextensions.dist
  • python310Packages.jupyterlab-lsp
  • python310Packages.jupyterlab-lsp.dist
  • python310Packages.langchain
  • python310Packages.langchain.dist
  • python310Packages.layoutparser
  • python310Packages.layoutparser.dist
  • python310Packages.pdfplumber
  • python310Packages.pdfplumber.dist
  • python310Packages.pymc
  • python310Packages.pymc.dist
  • python310Packages.textnets
  • python310Packages.textnets.dist
  • python310Packages.treex
  • python310Packages.treex.dist
  • python310Packages.unstructured-inference
  • python310Packages.unstructured-inference.dist
  • python310Packages.vega
  • python310Packages.vega.dist
  • python311Packages.jupyter-contrib-nbextensions
  • python311Packages.jupyter-contrib-nbextensions.dist
  • python311Packages.jupyterlab-lsp
  • python311Packages.jupyterlab-lsp.dist
  • python311Packages.layoutparser
  • python311Packages.layoutparser.dist
  • python311Packages.pdfplumber
  • python311Packages.pdfplumber.dist
  • python311Packages.unstructured-inference
  • python311Packages.unstructured-inference.dist
  • python311Packages.vega
  • python311Packages.vega.dist
  • tts
  • tts.dist
  • wolfram-notebook
220 packages built:
  • cantor
  • ihaskell
  • jupyter
  • jupyter.dist
  • labplot
  • nbqa
  • nbqa.dist
  • opsdroid
  • opsdroid.dist
  • python310Packages.ansible-kernel
  • python310Packages.ansible-kernel.dist
  • python310Packages.arviz
  • python310Packages.arviz.dist
  • python310Packages.augmax
  • python310Packages.augmax.dist
  • python310Packages.einops
  • python310Packages.einops.dist
  • python310Packages.encodec
  • python310Packages.encodec.dist
  • python310Packages.experiment-utilities
  • python310Packages.experiment-utilities.dist
  • python310Packages.fastai
  • python310Packages.fastai.dist
  • python310Packages.folium
  • python310Packages.folium.dist
  • python310Packages.jupyter
  • python310Packages.jupyter-collaboration
  • python310Packages.jupyter-collaboration.dist
  • python310Packages.jupyter-contrib-core
  • python310Packages.jupyter-contrib-core.dist
  • python310Packages.jupyter-highlight-selected-word
  • python310Packages.jupyter-highlight-selected-word.dist
  • python310Packages.jupyter-lsp
  • python310Packages.jupyter-lsp.dist
  • python310Packages.jupyter-nbextensions-configurator
  • python310Packages.jupyter-nbextensions-configurator.dist
  • python310Packages.jupyter-server
  • python310Packages.jupyter-server-fileid
  • python310Packages.jupyter-server-fileid.dist
  • python310Packages.jupyter-server-mathjax
  • python310Packages.jupyter-server-mathjax.dist
  • python310Packages.jupyter-server.dist
  • python310Packages.jupyter-sphinx
  • python310Packages.jupyter-sphinx.dist
  • python310Packages.jupyter.dist
  • python310Packages.jupyterlab
  • python310Packages.jupyterlab-git
  • python310Packages.jupyterlab-git.dist
  • python310Packages.jupyterlab.dist
  • python310Packages.jupyterlab_launcher
  • python310Packages.jupyterlab_launcher.dist
  • python310Packages.jupyterlab_server
  • python310Packages.jupyterlab_server.dist
  • python310Packages.jupytext
  • python310Packages.jupytext.dist
  • python310Packages.k-diffusion
  • python310Packages.k-diffusion.dist
  • python310Packages.labelbox
  • python310Packages.labelbox.dist
  • python310Packages.livelossplot
  • python310Packages.livelossplot.dist
  • python310Packages.memestra
  • python310Packages.memestra.dist
  • python310Packages.mkdocs-jupyter
  • python310Packages.mkdocs-jupyter.dist
  • python310Packages.nbclassic
  • python310Packages.nbclassic.dist
  • python310Packages.nbconflux
  • python310Packages.nbconflux.dist
  • python310Packages.nbconvert
  • python310Packages.nbconvert.dist
  • python310Packages.nbdev
  • python310Packages.nbdev.dist
  • python310Packages.nbdime
  • python310Packages.nbdime.dist
  • python310Packages.nbexec
  • python310Packages.nbexec.dist
  • python310Packages.nbsmoke
  • python310Packages.nbsmoke.dist
  • python310Packages.nbsphinx
  • python310Packages.nbsphinx.dist
  • python310Packages.nikola
  • python310Packages.nikola.dist
  • python310Packages.nix-kernel
  • python310Packages.nix-kernel.dist
  • python310Packages.notebook
  • python310Packages.notebook-shim
  • python310Packages.notebook-shim.dist
  • python310Packages.notebook.dist
  • python310Packages.notedown
  • python310Packages.notedown.dist
  • python310Packages.osmnx
  • python310Packages.osmnx.dist
  • python310Packages.phik
  • python310Packages.phik.dist
  • python310Packages.pweave
  • python310Packages.pweave.dist
  • python310Packages.pyls-memestra
  • python310Packages.pyls-memestra.dist
  • python310Packages.pymoo
  • python310Packages.pymoo.dist
  • python310Packages.qgrid
  • python310Packages.qgrid.dist
  • python310Packages.spacy
  • python310Packages.spacy-loggers
  • python310Packages.spacy-loggers.dist
  • python310Packages.spacy-lookups-data
  • python310Packages.spacy-lookups-data.dist
  • python310Packages.spacy-transformers
  • python310Packages.spacy-transformers.dist
  • python310Packages.spacy.dist
  • spyder (python310Packages.spyder)
  • spyder.dist (python310Packages.spyder.dist)
  • python310Packages.textacy
  • python310Packages.textacy.dist
  • python310Packages.thinc
  • python310Packages.thinc.dist
  • python310Packages.unstructured-api-tools
  • python310Packages.unstructured-api-tools.dist
  • python310Packages.vector
  • python310Packages.vector.dist
  • python310Packages.wasabi
  • python310Packages.wasabi.dist
  • python310Packages.xarray-einstats
  • python310Packages.xarray-einstats.dist
  • python311Packages.ansible-kernel
  • python311Packages.ansible-kernel.dist
  • python311Packages.augmax
  • python311Packages.augmax.dist
  • python311Packages.einops
  • python311Packages.einops.dist
  • python311Packages.encodec
  • python311Packages.encodec.dist
  • python311Packages.experiment-utilities
  • python311Packages.experiment-utilities.dist
  • python311Packages.folium
  • python311Packages.folium.dist
  • python311Packages.jupyter
  • python311Packages.jupyter-collaboration
  • python311Packages.jupyter-collaboration.dist
  • python311Packages.jupyter-contrib-core
  • python311Packages.jupyter-contrib-core.dist
  • python311Packages.jupyter-highlight-selected-word
  • python311Packages.jupyter-highlight-selected-word.dist
  • python311Packages.jupyter-lsp
  • python311Packages.jupyter-lsp.dist
  • python311Packages.jupyter-nbextensions-configurator
  • python311Packages.jupyter-nbextensions-configurator.dist
  • python311Packages.jupyter-server
  • python311Packages.jupyter-server-fileid
  • python311Packages.jupyter-server-fileid.dist
  • python311Packages.jupyter-server-mathjax
  • python311Packages.jupyter-server-mathjax.dist
  • python311Packages.jupyter-server.dist
  • python311Packages.jupyter-sphinx
  • python311Packages.jupyter-sphinx.dist
  • python311Packages.jupyter.dist
  • python311Packages.jupyterlab
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-git.dist
  • python311Packages.jupyterlab.dist
  • python311Packages.jupyterlab_launcher
  • python311Packages.jupyterlab_launcher.dist
  • python311Packages.jupyterlab_server
  • python311Packages.jupyterlab_server.dist
  • python311Packages.jupytext
  • python311Packages.jupytext.dist
  • python311Packages.labelbox
  • python311Packages.labelbox.dist
  • python311Packages.livelossplot
  • python311Packages.livelossplot.dist
  • python311Packages.memestra
  • python311Packages.memestra.dist
  • python311Packages.mkdocs-jupyter
  • python311Packages.mkdocs-jupyter.dist
  • python311Packages.nbclassic
  • python311Packages.nbclassic.dist
  • python311Packages.nbconflux
  • python311Packages.nbconflux.dist
  • python311Packages.nbconvert
  • python311Packages.nbconvert.dist
  • python311Packages.nbdev
  • python311Packages.nbdev.dist
  • python311Packages.nbdime
  • python311Packages.nbdime.dist
  • python311Packages.nbexec
  • python311Packages.nbexec.dist
  • python311Packages.nbsmoke
  • python311Packages.nbsmoke.dist
  • python311Packages.nbsphinx
  • python311Packages.nbsphinx.dist
  • python311Packages.nikola
  • python311Packages.nikola.dist
  • python311Packages.nix-kernel
  • python311Packages.nix-kernel.dist
  • python311Packages.notebook
  • python311Packages.notebook-shim
  • python311Packages.notebook-shim.dist
  • python311Packages.notebook.dist
  • python311Packages.notedown
  • python311Packages.notedown.dist
  • python311Packages.osmnx
  • python311Packages.osmnx.dist
  • python311Packages.pweave
  • python311Packages.pweave.dist
  • python311Packages.pyls-memestra
  • python311Packages.pyls-memestra.dist
  • python311Packages.qgrid
  • python311Packages.qgrid.dist
  • python311Packages.spyder
  • python311Packages.spyder.dist
  • python311Packages.thinc
  • python311Packages.thinc.dist
  • python311Packages.unstructured-api-tools
  • python311Packages.unstructured-api-tools.dist
  • python311Packages.wasabi
  • python311Packages.wasabi.dist
  • quarto
  • sage
  • sageWithDoc

@GaetanLepage
Copy link
Contributor Author

Lately I have been looking for the reasons why those packages fail to build and it doesn't seem to be related to this update/PR.

@ofborg ofborg bot requested a review from natsukium August 19, 2023 11:12
natsukium
natsukium approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it when CI passes.

@natsukium natsukium merged commit 193bf2f into NixOS:master Aug 20, 2023
21 checks passed
@GaetanLepage GaetanLepage deleted the jupyter-extensions branch August 20, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natsukium natsukium natsukium approved these changes

@figsoda figsoda Awaiting requested review from figsoda

@FRidh FRidh Awaiting requested review from FRidh

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@K900 K900 Awaiting requested review from K900

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GaetanLepage @SuperSandro2000 @natsukium