-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.poetry-core: 1.5.1 -> 1.6.1 #244535
Conversation
I get
on x86_64-darwin. That's the same issue as before: #220252 |
ae0a543
to
42a6ba4
Compare
cceedbd
to
3f1211a
Compare
So two derivations, and we divert for x86_64-darwin? This is annoying. |
Not necessarily. We could add even more patches to keep the vendored dependencies at their current versions. |
2ded0af
to
b052103
Compare
b052103
to
df047df
Compare
How does everyone feel about merging this? Starting in Except, it's broken now because So I see the following options:
I don't have a strong opinion which option we decide, but I'm hoping we can come up with a path forward. |
I think we can merge this PR and then decide whether to use a cleaner solution in the future. The packaging downgrade also happened before this PR, so this only changes the poetry-core version. |
patches = [ ]; | ||
nativeCheckInputs = old.nativeCheckInputs ++ [ | ||
self.tomli-w | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this override go away completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This was only needed because poetry used a different version of poetry-core than what's in pythonPackages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should merge this and follow up with a new PR to clean up these vendor patches.
Description of changes
Diff: python-poetry/poetry-core@1.5.1...1.6.1
Changelog: https://github.com/python-poetry/poetry-core/blob/1.6.1/CHANGELOG.md
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)