-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: mostly noop: refer to src.name
or similar in sourceRoot
where appropriate
#245388
Conversation
Rebased onto master to fix a conflict with |
I just checked the changes and many `rec` are added where `finalAttrs` pattern could be used. Don't you think it would be better to use directly `finalAttrs` instead?
I did use `finalAttrs` in the expression that used them already, I was trying to do the minimal change...
|
I know, but what I'm saying here is a bit different... I'm saying that we should avoid using |
The removal of rec can be done in other PRs. |
OfBorg seems to be stuck? Pending eval for 20 hours. |
@drupol I pushed a new commit that replaces all newly introduced |
Excellent, thanks !!!! |
aarch64-darwin usually spends days bootstrapping. |
Yay! All checks pass, still no conflicts. A prime opportunity to merge. :) |
Except merge conflicts. Maybe because I burned it up :( |
…appropriate, part 1: trivial cases
…appropriate, part 2: the non-trivial cases
…plementation, fix examples
…ec` with a fixpoint over `finalAttrs`
Rebased. |
🍻 |
This now has a continuation in #247977. |
Description of changes
This replaces all the uses of
sourceRoot = "source";
,sourceRoot = "source/subdir";
, and similar in package derivations that use the defaultunpackPhase
withsourceRoot = src.name
,sourceRoot = "${src.name}/subdir";
and similar.It also fixes
sourceRoot
andsetSourceRoot
description in the docs to match the implementation, and deprecates the old usage in release notes.The primary motivation for this change is to make #49862 (or its reverse) trivial to implement.
Things done
It's a mostly noop change except for the changes to documentation (which cause
nixos-install-tools
to be rebuilt).