inkscape: 1.2.2 -> 1.3, lib2geom: 1.2.2 -> 1.3 #245431
Conversation
|
I updated both in a single commit because Inkscape depends on lib2geom (same authors) and is the only dependant of it. |
|
Unfortunately this breaks on Darwin https://gitlab.com/inkscape/lib2geom/-/issues/62 and aarch64-linux https://gitlab.com/inkscape/lib2geom/-/issues/63 |
|
Then we will have to wait for a |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/inkscape-possible-domain-compromise/32008/5 |
Separate commits are generally preferred. Then you can link the relevant changelogs in the commit message easily, among other benefits. If you update lib2geom first, Inkscape should still work, unless the library broke the API. |
|
Is this still waiting on upstream fixes, or is this close to merging? Let me know if I can help any! |
|
|
@jtojnar can you take over this? I can't test it on Arm anyway. |
jtojnar
force-pushed
the
staging
branch
3 times, most recently
from
18bdad9
to
c4378d5
Compare
There was a problem hiding this comment.
I tested some basic operations and the hpgl import. Console complains about resource missing but apply-transform extension still appears to work and either way, it is not regression compared to 1.2:
$ nix-shell -I nixpkgs=$PWD -p "inkscape-with-extensions.override { inkscapeExtensions = null; }" --run inkscape
** (org.inkscape.Inkscape:252608): WARNING **: 22:38:53.378: Failed to find resource file 'inkex.py'. Looked in:
/home/jtojnar/.config/inkscape/extensions/inkex.py
(null)
/nix/store/cyfbhp0rx19gcrjmdka3vryy0bhnhl09-inkscape-with-extensions-1.3/share/inkscape/extensions/inkex.py
** (org.inkscape.Inkscape:252608): WARNING **: 22:38:53.786: You have a huge number of font families (1711), and Cairo is limiting the size of widgets you can draw.
Your preview cell height is capped to 17.
delroth
added
12.approvals: 1
There was a problem hiding this comment.
From https://gitlab.com/inkscape/lib2geom/-/issues/63 I get the impression that we shouldn't let that issue hold up the merge, right?
Tested this build with nix-shell -p "inkscape-with-extensions.override { inkscapeExtensions = [ inkscape-extensions.inkcut ]; }" --run inkscape, creating a simple image and opening it in inkcut. Unfortunately there seems to be something broken with the way inkcut converts objects to paths, but that seems to be an inkscape/inkcut problem, not a reason to hold back this PR IMHO (as inkcut nixpkgs package maintainer).
|
Status of filelock dependency still unclear, see #258885 (comment) |
|
v1.3 is still broken on darwin, and v1.3.1 is not going to be a long wait (Nov 15). |
https://gitlab.com/inkscape/lib2geom/-/releases/1.3 Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
This partly reverts 5d12e40 to avoid potential conflicts. Also move dependencies only introduced because of tests to checkInputs.
The dependency is not imported anywhere in the Inkscape code so let’s make the requirement explicit.
https://inkscape.org/doc/release_notes/1.3/Inkscape_1.3.html libepoxy for experimental GPU-accelerated rendering. pyparsing for HPGL support. Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
|
@ofborg build inkscape inkscape.passthru.tests |
(created inkcut/inkcut#374 for this problem) |
(not sure what changed, but this works fine now) |
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)