Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.customisation: uncurry makeScopeWithSplicing #245824

Merged
2 commits merged into from Jul 28, 2023
Merged

lib.customisation: uncurry makeScopeWithSplicing #245824

2 commits merged into from Jul 28, 2023

Commits on Jul 28, 2023

  1. lib.customisation: uncurry makeScopeWithSplicing 

    Deeply-curried functions are pretty error-prone in untyped languages
like Nix.  This is a particularly bad case because
`top-level/splice.nix` *also* declares a makeScopeWithSplicing, but
it takes *two fewer arguments*.

Let's switch to attrset-passing form, to provide some minimal level
of sanity-checking.
    Adam Joseph committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    cb13669 View commit details
    Browse the repository at this point in the history

  2. lib.makeScopeWithSplicing: provide default for keep,extra 

    These are often unneeded by the user.
    @Artturin
    Artturin committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    3716ef1 View commit details
    Browse the repository at this point in the history