qt5: remove overrideScope' #245905
Merged
qt5: remove overrideScope' #245905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of |
Artturin
reviewed
Jul 28, 2023
lelgenio
force-pushed
the
qt5-remove-override-scope-quote
branch
from
f1b691a
to
f6a944e
Compare
doronbehar
approved these changes
Aug 9, 2023
| @@ -329,9 +329,6 @@ let | |||
| propagatedBuildInputs = [ self.qtbase.dev buildPackages.makeBinaryWrapper ] | |||
| ++ lib.optional stdenv.isLinux self.qtwayland.dev; | |||
| } ../hooks/wrap-qt-apps-hook.sh; | |||
| } // lib.optionalAttrs config.allowAliases { | |||
| # remove before 23.11 | |||
There was a problem hiding this comment.
According to git blame @jtojnar added this message.
There was a problem hiding this comment.
I added the alias and the comment when i converted the set to use makeScopeWithSplicing. The purpose was to remove the alias before 23.11 :P
1 task
|
Successfully created backport PR for |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Throw error when accessing
qt5.overrideScope', previously issued a warning and redirected toqt5.overrideScope.Fixes: #245679
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)