Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcm: init at 1.9.0 #247027

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dcm: init at 1.9.0 #247027

wants to merge 2 commits into from

Conversation

NANASHI0X74
Copy link
Contributor

@NANASHI0X74 NANASHI0X74 commented Aug 3, 2023 •
edited
Loading

Description of changes

adds DCM package. DCM is a static analysis tool for dart: https://dcm.dev/

Things done

  • Built on platform(s)
    • x86_64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@NANASHI0X74
Copy link
Contributor Author

looks like dart executables won't work with patchelf: dart-lang/sdk#50926

@NANASHI0X74 NANASHI0X74 changed the title dcm: init at 1.7.2 dcm: init at 1.9.0 Sep 10, 2023
@NANASHI0X74
Copy link
Contributor Author

I switched to using an FHSEnv

@NANASHI0X74 NANASHI0X74 marked this pull request as ready for review September 10, 2023 18:24
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NANASHI0X74 @wegank