Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libavif: disable thumbnailer if !build.canExecute host #250900

Closed
wants to merge 1 commit into from
Closed

libavif: disable thumbnailer if !build.canExecute host #250900

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 23, 2023

Description of changes

As suggested by @lopsided98 here:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from lopsided98 August 23, 2023 05:07
@lopsided98
Copy link
Contributor

Is !canExecute correct? Building the thumbnailer is controlled by meson.is_cross_build(). Also, I already submitted nearly the same PR, except I didn't use canExecute and avoid a mass-rebuild by keeping the blank line: #250813

@ghost
Copy link
Author

ghost commented Aug 23, 2023

Also, I already submitted nearly the same PR

Sorry I just noticed that. There is no backlink to it in #250610. Also I already had this commit in my local tree.

except I didn't use canExecute and avoid a mass-rebuild by keeping the blank line: #250813

Clever!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant