Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust.lib: add toRustTargetForUseInEnvVars #251539

Closed
wants to merge 1 commit into from
Closed

rust.lib: add toRustTargetForUseInEnvVars #251539

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2023 •
edited by ghost
Loading

Description of changes

Split out from

so I can reference it in a review of

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

rust.lib: add toRustTargetForUseInEnvVars
2ade71d 
Split out from #247442 so I can
reference it in a review of
#251365
@ghost ghost mentioned this pull request Aug 26, 2023
Merged
12 tasks
@ghost ghost marked this pull request as ready for review August 26, 2023 08:48
@ghost ghost requested review from zowoq, winterqt and figsoda as code owners August 26, 2023 08:48
@ghost ghost mentioned this pull request Aug 26, 2023
Closed
12 tasks
yu-re-ka
yu-re-ka approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@yu-re-ka yu-re-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have needed this several times. Thanks!

@alyssais alyssais mentioned this pull request Sep 25, 2023
Merged
3 tasks
@alyssais alyssais closed this Oct 7, 2023
@ghost ghost deleted the pr/rust/cross/env-vars branch January 23, 2024 06:49
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

@winterqt winterqt Awaiting requested review from winterqt winterqt is a code owner

@figsoda figsoda Awaiting requested review from figsoda figsoda is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yu-re-ka @delroth @alyssais