libunwind: 1.6.2 -> 1.7.2 #253133
Merged
libunwind: 1.6.2 -> 1.7.2 #253133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2766 |
pbsds
requested changes
Oct 17, 2023
There was a problem hiding this comment.
nixpkgs-review is being a bit grumpy, so a review of the diff will have to do for now:
The switch from gnu savannah to github is mentioned here, but not discussed.
- The removed patch is tagged in 1.7.2
- loongarch64-linux is added in Add port for Linux on LoongArch libunwind/libunwind#316
changelog:
|
|
||
| src = fetchurl { | ||
| url = "mirror://savannah/libunwind/${pname}-${version}.tar.gz"; | ||
| sha256 = "sha256-SmrsZmmR+0XQiJxErt6K1usQgHHDVU/N/2cfnJR5SXY="; | ||
| url = "https://github.com/libunwind/libunwind/releases/download/v${version}/libunwind-${version}.tar.gz"; |
There was a problem hiding this comment.
Should we use their provided tarballs, or should we rather use fetchFromGitHub? I can't seem to find any CI job creating those tarballs.
The original upstream no longer publishs new tarballs, switch to GitHub. Remove upstreamed patch. Add new platforms supported by latest libunwind.
|
LGTM, built 5 reverse dependencies locally and they seem to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The original upstream no longer publishs new tarballs, switch to GitHub.
Remove upstreamed patch.
Add new platforms supported by latest libunwind.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)