[23.05] Backport simple package paths: part 1b #253442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the `pkgs/by-name` directory as proposed by RFC 140. Included are: - The implementation to add packages defined in that directory to the top-level package scope - Contributer documentation on how to add packages to it - A GitHub Actions workflow to check the structure of it on all PRs (cherry picked from commit f6467c3)
infinisil
requested review from
Ericson2314,
matthewbauer,
Mic92,
zowoq,
a team and
edolstra
as code owners
infinisil
changed the title
13 tasks
Ericson2314
approved these changes
Sep 5, 2023
Lord-Valen
approved these changes
Sep 6, 2023
wegank
added
the
12.approvals: 2
Mic92
approved these changes
Sep 7, 2023
wegank
added
12.approvals: 3+
|
Some small issues have been discovered, let's wait for these to be resolved, I'll include them here, and then wait a bit longer to see if something else comes up: |
Co-Authored-By: zowoq <59103226+zowoq@users.noreply.github.com> (cherry picked from commit 437d00d)
On Darwin, /tmp is sometimes a symlink to /private/tmp, which couldn't
be handled before:
error: access to canonical path '/private/var/folders/xp/9_ry6h9x6l9gh_g32qspz0_40000gp/T/.tmpFbcNO0' is forbidden in restricted mode
This both fixes that and adds a test to make sure it can't happen again
(cherry picked from commit d518eb9)
We seem to have enough tests to run into this now:
error: creating symlink from '/private/tmp/nix-build-nixpkgs-check-by-name.drv-0/source/test-tmp/var/nix/gcroots/profiles' to '/private/tmp/nix-build-nixpkgs-check-by-name.drv-0/source/test-tmp/var/nix/profiles': File exists
(cherry picked from commit 9c9a7e0)
|
I now included the above two fixes, nothing else has come up since, I think this is good to be backported now. @ofborg build tests.nixpkgs-check-by-name |
delroth
removed
the
12.approvals: 3+
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This is the backport of #237439, as written in RFC 140.
Notably we only need to backport the first commit of that PR, since it introduces the machinery and documentation for the new
pkgs/by-namedirectory. The other two commits aren't strictly necessary:hellotopkgs/by-nameisn't necessaryLet's only merge this in a couple days once we're sure that #237439 works without problems.
Things done
pkgs/by-namewith some mistakes and verified that the tool detects them