nixos/swraid: only warn if swraid was explicitly enabled #255426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
@GrahamcOfBorg test systemd-initrd-swraid |
The default just recently changed in 23.11. Users that had swraid enabled implicitly by NixOS in previous releases got surprised by warnings even though they do not actually use software RAID. Fixes NixOS#254807
ctheune
force-pushed
the
254807-backwards-compatibility-for-swraid-warnings
branch
from
826ff49 to
53f987c
Compare
github-actions
bot
added
8.has: documentation
ofborg
bot
added
10.rebuild-darwin: 0
|
Thanks! |
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default just recently changed in 23.11. Users that had swraid enabled implicitly by NixOS in previous releases got surprised by warnings even though they do not actually use software RAID.
Fixes #254807
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)