Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrobox: refactor code #255697

Merged
merged 2 commits into from
Sep 17, 2023
Merged

distrobox: refactor code #255697

merged 2 commits into from
Sep 17, 2023

Conversation

chewblacka
Copy link
Contributor

@chewblacka chewblacka commented Sep 17, 2023

Description of changes

Refactor code:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@chewblacka chewblacka marked this pull request as ready for review September 17, 2023 14:53
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 17, 2023
@wegank wegank merged commit 90b8bd9 into NixOS:master Sep 17, 2023
14 of 15 checks passed
@chewblacka chewblacka deleted the refactor-distrobox branch September 17, 2023 18:58
@github-actions
Copy link
Contributor

Backport failed for release-23.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-23.05
git worktree add -d .worktree/backport-255697-to-release-23.05 origin/release-23.05
cd .worktree/backport-255697-to-release-23.05
git checkout -b backport-255697-to-release-23.05
ancref=$(git merge-base 6a88110984d8bb2653ffe2abb57d18eabf3d7284 c0633919a68a239e71c9ffa281225c92f18e8060)
git cherry-pick -x $ancref..c0633919a68a239e71c9ffa281225c92f18e8060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants