llvmPackages_{15}.libcxxStdenv: fix '__cxxabi_config.h' file not found #255756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#include <cxxabi.h>` `/nix/store/02wpjmp2zjjxz13z7g599mniwi25zkcy-libcxxabi-16.0.6-dev/include/cxxabi.h:20:10: fatal error: '__cxxabi_config.h' file not found`
…_PATHS}` for all cxxabis Previously we only specified `LIBCXX_CXX_ABI_INCLUDE_PATHS` for `libcxxabi` and not for `libcxxrt` which causes `libcxx`'s build to fall back to looking in `/usr/include/c++/v1`: https://github.com/llvm/llvm-project/blob/aa656f6c2dec73faceeed21e15401d8f0c743c8b/libcxx/cmake/Modules/HandleLibCXXABI.cmake#L148-L151 We didn't set `LIBCXX_CXX_ABI_LIBRARY_PATH` (and this did not seem to be a problem; I think this gets defaulted elsewhere in the `libcxx` build) but it doesn't hurt to.
ofborg
bot
requested review from
sternenseemann,
primeos,
lovek323,
RaitoBezarius,
dtzWill,
alyssais,
Ericson2314 and
rrbutani
Artturin
force-pushed
the
llvmfixes1
branch
from
1961606
to
15f63a7
Compare
rrbutani
added
the
6.topic: llvm/clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)