prosody: remove deprecated libevent #256738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanderse
reviewed
Oct 9, 2023
| @@ -73,6 +73,7 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
|
|
|||
| passthru = { | |||
| withLibevent = withLibevent; | |||
There was a problem hiding this comment.
I don't think so
Suggested change
| withLibevent = withLibevent; |
12 tasks
Comment on lines
782
to
785
| ${ optionalString cfg.package.withLibevent '' | ||
| -- libevent was opted into (default is "epoll") | ||
| network_backend = "event" | ||
| '' } |
There was a problem hiding this comment.
Suggested change
| ${ optionalString cfg.package.withLibevent '' | |
| -- libevent was opted into (default is "epoll") | |
| network_backend = "event" | |
| '' } |
we might as well remove this
| @@ -779,8 +779,10 @@ in | |||
|
|
|||
| admins = ${toLua cfg.admins} | |||
|
|
|||
| @@ -73,6 +73,7 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
|
|
|||
| passthru = { | |||
| withLibevent = withLibevent; | |||
There was a problem hiding this comment.
I don't think so
Suggested change
| withLibevent = withLibevent; |
| @@ -2,7 +2,7 @@ | |||
| , icu | |||
| , lua | |||
| , nixosTests | |||
| , withLibevent ? true | |||
| , withLibevent ? false | |||
There was a problem hiding this comment.
I think we can even go as far and just drop that option entirely
12 tasks
`use_libevent` config option has been deprecated as there are 3 networking back-ends (see: https://prosody.im/doc/network_backend). It is probably unwise to stray from the defaults (epoll). Review instructed to flat-out remove it versus previously making it opt-in.
toastal
force-pushed
the
prosody-libevent-deprecated
branch
from
d223a47
to
ccb0f87
Compare
|
@SuperSandro2000 made adjustments. Could help until the rewrite is approved. |
|
Yes I agree we should go forward with this PR. We're to close to next release to merge the other PR at this point. |
toastal
changed the title
|
Is this good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_libeventconfig option has been deprecated as there are 3 networking back-ends (see: https://prosody.im/doc/network_backend). It is probably unwise to stray from the defaults (epoll).Description of changes
Info for this change provided by @Zash & @K900
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)