Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lunarml: unstable-2023-09-21 → 0.0.20230924 #257551

Merged
merged 1 commit into from
Nov 5, 2023
Merged

lunarml: unstable-2023-09-21 → 0.0.20230924 #257551

merged 1 commit into from
Nov 5, 2023

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Sep 27, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@toastal toastal mentioned this pull request Sep 27, 2023
Closed
12 tasks
@ofborg ofborg bot requested a review from ratsclub September 27, 2023 03:38
ratsclub
ratsclub approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ratsclub ratsclub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did work correctly on my codebase!

Thanks!

@K900 K900 merged commit 0a41eb1 into NixOS:master Nov 5, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratsclub ratsclub ratsclub approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toastal @ratsclub @K900