Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python311Packages.werkzeug: 2.3.7 -> 3.0.1; python311Packages.flask: 2.3.3 -> 3.0.1; python311Packages.quart: 0.18.4 -> 0.19.4 #258300

Merged
merged 13 commits into from
Jan 26, 2024
Merged

python311Packages.werkzeug: 2.3.7 -> 3.0.1; python311Packages.flask: 2.3.3 -> 3.0.1; python311Packages.quart: 0.18.4 -> 0.19.4 #258300

merged 13 commits into from
Jan 26, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 30, 2023 •
edited
Loading

https://werkzeug.palletsprojects.com/en/3.0.x/changes/#version-3-0-1
https://flask.palletsprojects.com/en/3.0.x/changes/#version-3-0-1
https://github.com/pallets/quart/blob/0.19.4/CHANGES.rst

This is a draft, because it is likely premature to upgrade these packages.

Breaks the following libraries:

I did test all other python libraries that carry the flask name.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fabaff, gebner, NickCao and AluisioASG October 1, 2023 00:02
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 22, 2023
@mweinelt mweinelt changed the base branch from staging-next to staging October 22, 2023 19:30
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 22, 2023
@ofborg ofborg bot requested a review from abbradar October 22, 2023 21:28
@CertainLach CertainLach mentioned this pull request Jan 25, 2024
Merged
18 tasks
@mweinelt mweinelt changed the title python311Packages.werkzeug: 2.3.7 -> 3.0.0; python311Packages.flask: 2.3.3 -> 3.0.0; python311Packages.quart: 0.18.4 -> 0.19.1 python311Packages.werkzeug: 2.3.7 -> 3.0.1; python311Packages.flask: 2.3.3 -> 3.0.1; python311Packages.quart: 0.18.4 -> 0.19.4 Jan 26, 2024
@mweinelt
Copy link
Member Author

mweinelt commented Jan 26, 2024 •
edited
Loading

This seems to break powerdns-admin (@Flakebi @zhaofengli), because flask-seasurf (unmaintained since 2022), has failing tests, due to api breakage.

@mweinelt
python311Packages.werkzeug: 2.3.7 -> 3.0.1
756efb5 
https://werkzeug.palletsprojects.com/en/3.0.x/changes/#version-3-0-1
@mweinelt
python311Packages.flask: 2.3.3 -> 3.0.1
a24d9a6 
https://flask.palletsprojects.com/en/3.0.x/changes/#version-3-0-1
@mweinelt
python311Packages.quart: 0.18.4 -> 0.19.4
138f345 
https://github.com/pallets/quart/blob/0.19.4/CHANGES.rst
@mweinelt
python311Packages.json-logging: test quart integration
df14441
@mweinelt
python311Packages.sentry-sdk: add quart optional
e5d3d38 
and prune unused package arguments.
@mweinelt
python311Packages.httpbin: backport flask 3.0 support
ac2b358
@mweinelt
python311Packages.flask-basicauth: drop
d2c9ee5 
Not compatible with Flask 3.0 and upstream is essentially dead.
@mweinelt
python311Packages.flask-sessionstore: drop
569fb19 
Incompatible with Flask 3.0 and unmaintained since 2017.
@mweinelt
python311Packages.flask-session-captcha: fix build with flask 3.0
22e6903 
Applies a patch that fixes the markupsafe import. Tests still don't work.
@mweinelt
python311Packages.flask-autoindex: drop
68c9550 
Incompatible with Flask 3.0 and unmaintained since 2020.
@mweinelt
python311Packages.flask-api: fix flask 3.0 compat, enable tests
2cee7f3
@mweinelt
python311Packages.flask-restful: fix tests
5313701 
Signals are now always available, since flask depends on blinker.
@mweinelt
python311Packages.flask-gravatar: fix flask 3.0 compat
8592e8e
@mweinelt mweinelt marked this pull request as ready for review January 26, 2024 01:42
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Jan 26, 2024
@ofborg ofborg bot requested review from gador and Flakebi January 26, 2024 02:04
@gador gador mentioned this pull request Jan 26, 2024
Merged
13 tasks
@gador
Copy link
Member

gador commented Jan 26, 2024

Changes LGTM. A fix for pgadmin4 is in #284100

@mweinelt mweinelt merged commit 273d8b2 into NixOS:staging Jan 26, 2024
28 checks passed
@mweinelt mweinelt deleted the quart-0.19.1 branch January 26, 2024 21:35
@Flakebi
Copy link
Member

Flakebi commented Feb 28, 2024

This seems to break powerdns-admin (@Flakebi @zhaofengli), because flask-seasurf (unmaintained since 2022), has failing tests, due to api breakage.

Thanks for the heads-up. A fix is in #292178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff Awaiting requested review from fabaff

@gebner gebner Awaiting requested review from gebner

@NickCao NickCao Awaiting requested review from NickCao

@AluisioASG AluisioASG Awaiting requested review from AluisioASG

@abbradar abbradar Awaiting requested review from abbradar

@gador gador Awaiting requested review from gador

@Flakebi Flakebi Awaiting requested review from Flakebi

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
Staging
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @gador @Flakebi