nixos/nixos-containers: add restartIfChanged option #260291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
donovanglover
added
the
6.topic: nixos-container
ofborg
bot
added
10.rebuild-darwin: 0
jian-lin
reviewed
Oct 11, 2023
donovanglover
force-pushed
the
nixos-containers/optional-restart
branch
from
fe18980
to
d867a9f
Compare
This commit makes auto-restarting declarative containers optional. This is useful when you don't want changes to your config to automatically restart the container and thus stop any applications running inside it.
donovanglover
force-pushed
the
nixos-containers/optional-restart
branch
from
d867a9f
to
fd7daf9
Compare
jian-lin
approved these changes
Oct 12, 2023
delroth
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit makes auto-restarting declarative containers optional.
This is useful when you don't want changes to your config to automatically restart the container and thus stop any applications running inside it.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)