Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.opencv3: remove #260727

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Oct 12, 2023

Description of changes

Update all Python packages (and one non-Python package) to use opencv4 except in the case of moviepy, where I removed the optional opencv3 dependence (disabled by default).

See also #256550 where the same was done for non-Python packages (between these two PRs, this leaves only haskellPackages.{opencv,opencv-extra}, which are unbuildable as they depend on broken haskellPackages.repa, and opencv3 itself).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lucasew
Copy link
Contributor

lucasew commented Oct 12, 2023

Result of nixpkgs-review pr 260727 run on x86_64-linux 1

1 package marked as broken and skipped:
  • frigate
2 packages failed to build:
  • python311Packages.camelot
  • python311Packages.camelot.dist
31 packages built:
  • easyocr (python310Packages.easyocr)
  • easyocr.dist (python310Packages.easyocr.dist)
  • home-assistant-component-tests.dremel_3d_printer
  • python310Packages.bpycv
  • python310Packages.bpycv.dist
  • python310Packages.camelot
  • python310Packages.camelot.dist
  • python310Packages.dremel3dpy
  • python310Packages.dremel3dpy.dist
  • python310Packages.imagecorruptions
  • python310Packages.imagecorruptions.dist
  • python310Packages.imantics
  • python310Packages.imantics.dist
  • python310Packages.imutils
  • python310Packages.imutils.dist
  • python310Packages.stytra
  • python310Packages.stytra.dist
  • python310Packages.vidstab
  • python310Packages.vidstab.dist
  • python311Packages.dremel3dpy
  • python311Packages.dremel3dpy.dist
  • python311Packages.easyocr
  • python311Packages.easyocr.dist
  • python311Packages.imagecorruptions
  • python311Packages.imagecorruptions.dist
  • python311Packages.imantics
  • python311Packages.imantics.dist
  • python311Packages.imutils
  • python311Packages.imutils.dist
  • python311Packages.vidstab
  • python311Packages.vidstab.dist

@bcdarwin
Copy link
Member Author

bcdarwin commented Oct 12, 2023

Result of nixpkgs-review pr 260727 run on x86_64-linux 1
1 package marked as broken and skipped:

* frigate

2 packages failed to build:

* python311Packages.camelot

* python311Packages.camelot.dist

31 packages built:
...

python311Packages.camelot builds for me on x86, not sure what the issue is here.

@lucasew
Copy link
Contributor

lucasew commented Oct 12, 2023

It fails right after start with failed to import setuptools. I will run it again.

@lucasew
Copy link
Contributor

lucasew commented Oct 12, 2023

Result of nixpkgs-review pr 260727 run on x86_64-linux 1

1 package marked as broken and skipped:
  • frigate
2 packages failed to build:
  • python311Packages.camelot
  • python311Packages.camelot.dist
31 packages built:
  • easyocr (python310Packages.easyocr)
  • easyocr.dist (python310Packages.easyocr.dist)
  • home-assistant-component-tests.dremel_3d_printer
  • python310Packages.bpycv
  • python310Packages.bpycv.dist
  • python310Packages.camelot
  • python310Packages.camelot.dist
  • python310Packages.dremel3dpy
  • python310Packages.dremel3dpy.dist
  • python310Packages.imagecorruptions
  • python310Packages.imagecorruptions.dist
  • python310Packages.imantics
  • python310Packages.imantics.dist
  • python310Packages.imutils
  • python310Packages.imutils.dist
  • python310Packages.stytra
  • python310Packages.stytra.dist
  • python310Packages.vidstab
  • python310Packages.vidstab.dist
  • python311Packages.dremel3dpy
  • python311Packages.dremel3dpy.dist
  • python311Packages.easyocr
  • python311Packages.easyocr.dist
  • python311Packages.imagecorruptions
  • python311Packages.imagecorruptions.dist
  • python311Packages.imantics
  • python311Packages.imantics.dist
  • python311Packages.imutils
  • python311Packages.imutils.dist
  • python311Packages.vidstab
  • python311Packages.vidstab.dist

@bcdarwin
Copy link
Member Author

I'm unable to reproduce this locally. (In any case, surely it's not related to opencv.)

@bcdarwin
Copy link
Member Author

Pushed an update changing the camelot build to use pyproject (and explicitly added setuptools as a dependency).

@lucasew
Copy link
Contributor

lucasew commented Oct 12, 2023

Result of nixpkgs-review pr 260727 run on x86_64-linux 1

2 packages failed to build:
  • python311Packages.camelot
  • python311Packages.camelot.dist
31 packages built:
  • easyocr (python310Packages.easyocr)
  • easyocr.dist (python310Packages.easyocr.dist)
  • home-assistant-component-tests.dremel_3d_printer
  • python310Packages.bpycv
  • python310Packages.bpycv.dist
  • python310Packages.camelot
  • python310Packages.camelot.dist
  • python310Packages.dremel3dpy
  • python310Packages.dremel3dpy.dist
  • python310Packages.imagecorruptions
  • python310Packages.imagecorruptions.dist
  • python310Packages.imantics
  • python310Packages.imantics.dist
  • python310Packages.imutils
  • python310Packages.imutils.dist
  • python310Packages.stytra
  • python310Packages.stytra.dist
  • python310Packages.vidstab
  • python310Packages.vidstab.dist
  • python311Packages.dremel3dpy
  • python311Packages.dremel3dpy.dist
  • python311Packages.easyocr
  • python311Packages.easyocr.dist
  • python311Packages.imagecorruptions
  • python311Packages.imagecorruptions.dist
  • python311Packages.imantics
  • python311Packages.imantics.dist
  • python311Packages.imutils
  • python311Packages.imutils.dist
  • python311Packages.vidstab
  • python311Packages.vidstab.dist

@bcdarwin
Copy link
Member Author

For unknown reasons nixpkgs-review is adding /nix/store/yyj8j05h1m5m8hg6pkc8xxvdad05imcw-python3.10-pdfminer-six-20221105 to propagatedBuildInputs, which breaks the build somehow due to being the wrong python version.

@bcdarwin
Copy link
Member Author

It's because pdfminer isn't a Python package as the Python package is pdfminer-six, so it gets built with buildPythonApplication and python3 = python310.

@github-actions github-actions bot removed 6.topic: ocaml 6.topic: nodejs 6.topic: cinnamon 6.topic: Enlightenment DE The Enlightenment Desktop Environment 6.topic: lib The Nixpkgs function library labels Oct 12, 2023
@lucasew
Copy link
Contributor

lucasew commented Oct 12, 2023

Result of nixpkgs-review pr 260727 run on x86_64-linux 1

33 packages built:
  • easyocr (python310Packages.easyocr)
  • easyocr.dist (python310Packages.easyocr.dist)
  • home-assistant-component-tests.dremel_3d_printer
  • python310Packages.bpycv
  • python310Packages.bpycv.dist
  • python310Packages.camelot
  • python310Packages.camelot.dist
  • python310Packages.dremel3dpy
  • python310Packages.dremel3dpy.dist
  • python310Packages.imagecorruptions
  • python310Packages.imagecorruptions.dist
  • python310Packages.imantics
  • python310Packages.imantics.dist
  • python310Packages.imutils
  • python310Packages.imutils.dist
  • python310Packages.stytra
  • python310Packages.stytra.dist
  • python310Packages.vidstab
  • python310Packages.vidstab.dist
  • python311Packages.camelot
  • python311Packages.camelot.dist
  • python311Packages.dremel3dpy
  • python311Packages.dremel3dpy.dist
  • python311Packages.easyocr
  • python311Packages.easyocr.dist
  • python311Packages.imagecorruptions
  • python311Packages.imagecorruptions.dist
  • python311Packages.imantics
  • python311Packages.imantics.dist
  • python311Packages.imutils
  • python311Packages.imutils.dist
  • python311Packages.vidstab
  • python311Packages.vidstab.dist

@ofborg ofborg bot requested a review from 2gn October 13, 2023 02:00
@marsam marsam merged commit 05d4a38 into NixOS:master Nov 6, 2023
21 of 22 checks passed
@bcdarwin bcdarwin deleted the opencv-python-updates branch November 6, 2023 04:22
@mweinelt mweinelt mentioned this pull request Nov 14, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants