Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nng: 1.6.0-prerelease update for rPackages.nanonext #261763

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

nviets
Copy link
Contributor

@nviets nviets commented Oct 18, 2023

Description of changes

Updating nng for rPackages.nanonext.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nviets nviets marked this pull request as ready for review October 18, 2023 04:04
@nviets
Copy link
Contributor Author

nviets commented Oct 18, 2023

@nixpkgs-merge-bot merge

@nviets
Copy link
Contributor Author

nviets commented Oct 18, 2023

@NixOS/nixpkgs-merge-bot merge

@Lassulus
Copy link
Member

That doesn't work for new packages and the bot is not live yet

@nviets
Copy link
Contributor Author

nviets commented Oct 19, 2023

Result of nixpkgs-review pr 261763 run on aarch64-darwin 1

1 package built:
  • nng

@nviets
Copy link
Contributor Author

nviets commented Oct 19, 2023

@jbedo - this update aligns the nng package with the version used in the nanonext R Package. Nanonext is a dependency of mirai, crew, and targets. See the hash used here. Would you mind merging?

@jbedo jbedo merged commit 8dd4592 into NixOS:master Nov 5, 2023
27 checks passed
@jbedo
Copy link
Contributor

jbedo commented Nov 5, 2023

LGTM, sorry for delay been on holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants