Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libunwind to Heroic and Steam FHS envs #262184

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Add libunwind to Heroic and Steam FHS envs #262184

merged 2 commits into from
Nov 5, 2023

Conversation

aidalgol
Copy link
Contributor

Description of changes

In recent bleeding-edge versions of Wine and Proton, ntdll.so needs libunwind.so.8.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@aidalgol
Copy link
Contributor Author

nixpkgs-review produces an error for steam-run, but I can build it with nix-build -A steam-run, and it runs just fine.

error: build log of '/nix/store/4v2xr2k4k5wzlrzf3mn1sn7d9ld8g6w3-steam-run.drv^*' is not available

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100 labels Oct 20, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2848

@ghost
Copy link

ghost commented Oct 31, 2023

Result of nixpkgs-review pr 262184 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • heroic
  • itch
15 packages built:
  • game-rs
  • kodiPackages.steam-launcher
  • lutris
  • minigalaxy
  • minigalaxy.dist
  • playonlinux
  • protontricks
  • protontricks.dist
  • steam (steamPackages.steam-fhsenv)
  • steam-run
  • steam-small (steamPackages.steam-fhsenv-small)
  • steam-tui
  • steamPackages.steam-fhsenv-without-steam
  • steamcmd (steamPackages.steamcmd)
  • xivlauncher

@aidalgol
Copy link
Contributor Author

heroic is stuck on an EOL'd Electron version until upstream updates to work with current Electrion, and Itch is pinned to Electron 11 for some reason.

ghost
ghost approved these changes Oct 31, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1198

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 5, 2023
@FliegendeWurst FliegendeWurst added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 5, 2023
@K900 K900 merged commit e437fe2 into NixOS:master Nov 5, 2023
26 checks passed
@aidalgol aidalgol deleted the missing-game-fhsenv-libs branch August 19, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

@CobaltCause CobaltCause Awaiting requested review from CobaltCause

@jonringer jonringer Awaiting requested review from jonringer

@Henry-Hiles Henry-Hiles Awaiting requested review from Henry-Hiles

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aidalgol @nixos-discourse @FliegendeWurst @K900