Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: remove hack for old kernels #262499

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Oct 21, 2023

Description of changes

The oldest kernel supported in Nixpkgs is now 4.19 LTS, so we don't need this any more.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The oldest kernel supported in Nixpkgs is now 4.19 LTS, so we don't
need this any more.
@fabianhjr
Copy link
Member

Building 6.5.7-hardened1

@fabianhjr fabianhjr self-requested a review October 21, 2023 18:13
@fabianhjr
Copy link
Member

fabianhjr commented Oct 21, 2023

Had a conflict, there was a related change on staging that hasn't made it to staging-next nor the main branch: #245968

@alyssais
Copy link
Member Author

Yeah, that's why this PR targets staging.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 21, 2023
@fabianhjr
Copy link
Member

Ah right, missed that and was using git am. Already passed the config phase and finishing up compilation.

@alyssais alyssais merged commit 96fe81f into NixOS:staging Oct 21, 2023
27 of 28 checks passed
@alyssais alyssais deleted the linux-4.14-cleanup branch October 21, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants