Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agda 2.6.4 updates #262814

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Agda 2.6.4 updates #262814

merged 7 commits into from
Oct 29, 2023

Conversation

ncfavier
Copy link
Member

#262645 bumps Agda to 2.6.4. This PR updates some Agda packages to work with 2.6.4, and marks the broken ones as broken.

Tested with nixosTests.agda and agda.tests.allPackages.

@github-actions github-actions bot added the 6.topic: agda "A dependently typed programming language / interactive theorem prover" label Oct 22, 2023
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 24, 2023
@turion
Copy link
Contributor

turion commented Oct 25, 2023

Thanks a lot! It would be great if we could have some grace period to give the packages some time to update, open upstream issues and ping maintainers. I find that marking libraries as broken should only be the last measure, when we are certain that we cannot expect timely upstream fixes.

@alexarice
Copy link
Contributor

Thanks a lot! It would be great if we could have some grace period to give the packages some time to update, open upstream issues and ping maintainers. I find that marking libraries as broken should only be the last measure, when we are certain that we cannot expect timely upstream fixes.

I don't think we have this option, as Agda automatically updates as part of the haskell package set to my knowledge

@ncfavier
Copy link
Member Author

Right, the grace period would have to delay the scheduled merge of haskell-updates. As soon as that branch is merged into master, those libraries will be broken, so marking them broken is just saving build time.

I don't think enough people care about agda-prelude and functional-linear-algebra to justify that. I'll report the issues upstream though.

@turion
Copy link
Contributor

turion commented Oct 25, 2023

Yes we do, the haskell updates branch is not merged immediately, there is some time until it is merged. If we can make progress with broken packages in that time, we can merge them unbroken.

@turion
Copy link
Contributor

turion commented Oct 25, 2023

Ah ok, I see your point. So we mark them broken and try to fix them while haskell-updates is stabilized. So it is always in a mergeable state and haskell-updates is not delayed. That's a good process.

Then I think the only thing left to do is ping maintainers for the broken packages.

CC @laMudri @ryanorendorff

@alexarice
Copy link
Contributor

I think I've asked this before, but is it completely unreasonable to maintain Agda outside of the main haskell package set, so that we can choose when to update it/ potentially support multiple versions?

@turion
Copy link
Contributor

turion commented Oct 25, 2023

but is it completely unreasonable to maintain Agda outside of the main haskell package set, so that we can choose when to update it/ potentially support multiple versions?

If it's easy enough to decouple from the Haskell package set sufficiently then I think this is a great idea. But since Agda itself is written in Haskell, there are going to be some dependencies. We can fix an agda version or several in pkgs/development/haskell-modules/configuration-hackage2nix/main.yaml, and as long as these work with the rest of the Haskell package set, everything is fine. We'd still need to keep the compatibility matrix of agda libraries somewhere. Would you want to have one version of every agda library per agda version, or one agda-global version of every library?

@turion
Copy link
Contributor

turion commented Oct 25, 2023

@ofborg build agda.passthru.tests.allPackages

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 25, 2023
@ofborg ofborg bot requested a review from alexarice October 25, 2023 12:46
@ncfavier ncfavier merged commit 29a23fb into NixOS:haskell-updates Oct 29, 2023
@ncfavier ncfavier deleted the agda-updates branch October 29, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: agda "A dependently typed programming language / interactive theorem prover" 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants