Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spandsp: fix function argument name (typo) #262842

Merged
1 commit merged into from Dec 1, 2023
Merged

spandsp: fix function argument name (typo) #262842

1 commit merged into from Dec 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2023

Description of changes

The function here is being passed to overrideAttrs, not mkDerivation, so it should be named previousAttrs, not finalAttrs. This was my mistake.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The function here is being passed to `overrideAttrs`, not
`mkDerivation`, so it should be named `previousAttrs`, not
`finalAttrs`.  This was my mistake.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 23, 2023
@ghost ghost marked this pull request as ready for review November 12, 2023 00:07
@ghost
Copy link
Author

ghost commented Dec 1, 2023

This is just a stylistic fix, changing the name of a lambda-bound variable to be less confusing. Since it is trivial I will self-merge it without a review.

@ghost ghost merged commit 7e0464a into NixOS:master Dec 1, 2023
23 checks passed
@ghost ghost deleted the pr/spandsp/fix-typo branch December 1, 2023 22:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants