Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: create dummy crtstuff on S390 as well #262885

Merged
1 commit merged into from Oct 25, 2023
Merged

gcc: create dummy crtstuff on S390 as well #262885

1 commit merged into from Oct 25, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2023

Description of changes

This commit replicates the fix in #258032 for S390 as well.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost linked an issue Oct 23, 2023 that may be closed by this pull request
@ghost ghost marked this pull request as ready for review October 23, 2023 09:13
@ghost ghost requested a review from Artturin October 24, 2023 02:26
@ghost
Copy link
Author

ghost commented Oct 24, 2023

Squashed, rebased.

@ghost
Copy link
Author

ghost commented Oct 24, 2023

Dammit something went wrong when I squashed.

@ghost ghost requested a review from Artturin October 24, 2023 23:34
This commit replicates the fix in
#258032 for S390 as well.

Co-authored-by: Artturi <Artturin@artturin.com>
@ghost ghost merged commit 425cac9 into NixOS:master Oct 25, 2023
22 checks passed
@ghost ghost deleted the pr/crtstuff/s390 branch October 25, 2023 08:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgsCross.s390.stdenv broken by #238154
2 participants