-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lunar-client: migrate to by-name and add updateScript #263015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 263015
run on x86_64-linux 1
1 package built:
- lunar-client
Hash & fetched binary works. Update script tested by setting version to 3.0.0
and running it, which correctly reset everything to the values in this PR. LGTM.
Was trying my hardest to see if update-source-version
could be used instead of sed
ing around in the package file, but it can't handle appimageTools.wrapType2
-> appimageTools.wrapAppImage
-> buildFHSEnv
not setting a version
🙁.
also please lmk if this script will work with r-ryantm bot :)
If it works for nix-shell maintainers/scripts/update.nix --argstr package lunar-client
, then it should work for the update bot.
yeah, I spent quite lots of time trying that already |
(I guess this package is also lacking (and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test the updater script with nix-update lunar-client -u
Result of 1 package built:
Builds and runs fine, tested the update script. LGTM |
Description of changes
as in title.
also please lmk if this script will work with r-ryantm bot :)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)