Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: pad headers at link time to prevent install_name_tool failure on Darwin #263833

Merged
merged 1 commit into from
Nov 5, 2023
Merged

ghostscript: pad headers at link time to prevent install_name_tool failure on Darwin #263833

merged 1 commit into from
Nov 5, 2023

Conversation

xworld21
Copy link
Contributor

@xworld21 xworld21 commented Oct 27, 2023 •
edited
Loading

Description of changes

Fix #263489

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 27, 2023
amarshall
amarshall approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed builds successfully on x86_64-darwin. Thanks!

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2863

@xworld21 xworld21 mentioned this pull request Nov 5, 2023
Merged
13 tasks
@veprbl veprbl merged commit 87d7169 into NixOS:master Nov 5, 2023
23 checks passed
@cafkafk cafkafk mentioned this pull request Nov 9, 2023
Closed
13 tasks
nyabinary pushed a commit to nyabinary/nixpkgs that referenced this pull request Nov 14, 2023
@xworld21 @nyabinary
ghostscript: pad headers at link time to prevent install_name_tool fa…
e73dc79 
…ilure on Darwin (NixOS#263833)
@xworld21 xworld21 deleted the ghostscript-darwin branch March 21, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarshall amarshall amarshall approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: ghostscriptX on x86_64-darwin
4 participants
@xworld21 @nixos-discourse @amarshall @veprbl