Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kanidm: 1.1.0-beta.13 -> 1.1.0-rc.15 #264658

Merged
merged 1 commit into from
Nov 6, 2023
Merged

kanidm: 1.1.0-beta.13 -> 1.1.0-rc.15 #264658

merged 1 commit into from
Nov 6, 2023

Conversation

adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Oct 31, 2023 •
edited
Loading

Description of changes

https://github.com/kanidm/kanidm/releases/tag/v1.1.0-rc.15

Currently failing a test, so not ready yet. Maintainers feel free to edit my PR if I'm not around.

Failing test disabled upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Flakebi and erictapen October 31, 2023 22:05
@adamcstephens adamcstephens marked this pull request as ready for review November 1, 2023 11:54
@adamcstephens
Copy link
Contributor Author

adamcstephens commented Nov 1, 2023 •
edited
Loading

This is now building and ready for review.

Result of nixpkgs-review pr 264658 run on x86_64-linux 1

1 package built:
  • kanidm

Result of nixpkgs-review pr 264658 run on aarch64-linux 1

1 package built:
  • kanidm

@ofborg test kanidm

🍕 🍕 🍕

@Kranzes
Copy link
Member

Kranzes commented Nov 2, 2023

@ofborg test kanidm

Flakebi
Flakebi approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Test runs through (nix-build -A kanidm.tests) and seems to work fine on my system.

pkgs/servers/kanidm/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from Flakebi November 3, 2023 03:00
Flakebi
Flakebi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, still LGTM

erictapen
erictapen approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kranzes
Copy link
Member

Kranzes commented Nov 3, 2023

Are CI checks screwed up? Should I merge anyway?

@adamcstephens
Copy link
Contributor Author

Are CI checks screwed up? Should I merge anyway?

I hate to merge failing builds. I'm re-running these locally to test and see if I can reproduce the failure.

@adamcstephens
Copy link
Contributor Author

Both x86_64 and aarch64 tests run successfully me.

The errors from the ofborg failures seem to be:

server # [    5.189970] (kanidmd)[846]: kanidm.service: Failed to set up mount namespacing: /run/systemd/mount-rootfs/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ofborg-evaluator-1/nixos/tests/common/acme/server: No such file or directory
server # [    5.192497] (kanidmd)[846]: kanidm.service: Failed at step NAMESPACE spawning /nix/store/wqpcn0626p7a6sgpn2bc3aispsqa90v1-kanidm-1.1.0-rc.15/bin/kanidmd: No such file or directory

@mweinelt
Copy link
Member

mweinelt commented Nov 3, 2023 •
edited
Loading

Some hardening option on the systemd unit interferes with test runs on ofborg infra. This is not news, has happened on every update to kanidm before this one as well.

I suspect it is TemporaryFilesystem.

@Kranzes
Copy link
Member

Kranzes commented Nov 3, 2023

Shall we merge?

@Flakebi
Copy link
Member

Flakebi commented Nov 6, 2023

Shall we merge?

Yes, please. From what @mweinelt says, it’s definitely not a regression (and the test passes fine outside of ofborg).

@Kranzes Kranzes merged commit f9ef870 into NixOS:master Nov 6, 2023
27 of 29 checks passed
@adamcstephens adamcstephens deleted the kanidm/1.1.0-rc.15 branch January 14, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@erictapen erictapen erictapen approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamcstephens @Kranzes @mweinelt @Flakebi @erictapen @delroth